Add ruby-2.6 support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safafa
force-pushed
the
ruby-2.6-support
branch
from
1d6b293
to
c7bc23b
Compare
DanielePalombo
requested changes
Oct 6, 2023
Comment on lines
+12
to
+16
| if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('2.6') | ||
| gem 'rubocop' | ||
| else | ||
| gem 'rubocop', '~> 1.50.2' | ||
| end |
There was a problem hiding this comment.
@MassimilianoLattanzio WDYT about it?
safafa
force-pushed
the
ruby-2.6-support
branch
from
c7bc23b
to
cc2f971
Compare
DanielePalombo
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to ruby 2.6, it also regresses rubocop version from
1.54.2to1.50.2since it's the last version that supports ruby 2.6Severity:
Before submitting the PR make sure the following are checked:
main(if not - rebase it)./config/default.yml