Added sales total by products #38
Open
+111
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Aug 22, 2022
| <tr> | ||
| <td><%= currency %></td> | ||
| <td> | ||
| <% if (variant = ::Spree::Variant.where(id: variant_id).first) %> |
There was a problem hiding this comment.
Can we eager load in the controller this to prevent a N+1 query here, please?
| @@ -6,6 +6,8 @@ | |||
| collection do | |||
| get :sales_total | |||
| post :sales_total | |||
| get :sales_total_by_product | |||
| post :sales_total_by_product | |||
There was a problem hiding this comment.
Not sure why we would need the post route here.
| <% admin_breadcrumb(link_to t('spree.reports'), spree.admin_reports_path) %> | ||
| <% admin_breadcrumb(t('spree.sales_total_by_product')) %> | ||
|
|
||
| <% content_for :page_actions do %> |
There was a problem hiding this comment.
This empty block can be omitted
| </tbody> | ||
| </table> | ||
| <div style="text-align: center"> | ||
| <i>Not including tax, shipping, and adjustments</i> |
There was a problem hiding this comment.
Can we translate this note, please?
| @totals[order.currency][:sales_total] += line_item.display_amount.money | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Would like to see a spec for this
| def sales_total | ||
| params[:q] = search_params | ||
|
|
||
| @search = Order.complete.not_canceled.ransack(params[:q]) | ||
| @search = Order.complete.not_canceled.where(payment_state: "paid").ransack(params[:q]) |
There was a problem hiding this comment.
This change seems to break the existing specs.
| @orders = @search.result | ||
|
|
||
| Rails.logger.info("Orders Total: #{@orders.count}") |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.