This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Pull across recent updates #6
Open
dankmitchell
wants to merge
19
commits into
solidusio-contrib:master
Choose a base branch
from
Lostmyname:lmn-2.0.3-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in spree-contrib/better_spree_paypal_express PR 101 but there are no details on why.
This has been removed from Solidus.
This is now required by Solidus
Avoid deprecation warning: DEPRECATION WARNING: Spree::Core::Engine.add_routes is deprecated, use Spree::Core::Engine.routes.draw instead.
This reverts an iframe-related change from 2474ae3 and adds a sleep hack.
TODO: - Make this an option instead of being hard-coded - Fix & update specs
The Gemfile update is because this gem isn't being maintained.
Use outstanding balance instead of total
discounted_cost -> final_amount_without_additional_tax
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.