Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tween docs: flesh out description, define all arguments #720

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

edemaine
Copy link
Contributor

I used @solid-primitives/tween the other day and it was sooo lovely and simple. Well done: it was exactly what I wanted.

The docs fell a little short. Currently you need to read the code to know about the ease option, or to know how it works internally (requestAnimationFrame). So I fleshed out the README accordingly.

I couldn't test locally to see that the docs format OK. When I tried pnpm install; pnpm dev, I got the error No packages found. Did you run `pnpm generate` . And pnpm generate fails (no such script). How do I generate the src directory?

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 100628b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetarnav
Copy link
Member

the generate script is in the site package

"generate": "tsx ./scripts/generate.ts",

probably should be in root too

@thetarnav thetarnav merged commit 9d3df76 into solidjs-community:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants