Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Solid's createMutable to new mutable package #519

Merged
merged 12 commits into from
Oct 6, 2023
Merged

Move Solid's createMutable to new mutable package #519

merged 12 commits into from
Oct 6, 2023

Conversation

thetarnav
Copy link
Member

This copies the current implementation of createMutable in solid 1.7.12 one-to-one, as the primitive is planned to be removed in core in future releases.
As the API is still useful to many people, it will be continued to be developed and maintained here.
The v1 of this package should remain the same as it was in solid, to avoid breaking existing apps, but later it can be extended past the current implementation, as it won't be "held back" by the tight compatibility with createStore.
createMutable in solid was some internal logic from createStore implementation, so using both createMutable and createStore in your app will mean larger bundle size after the move.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: f43aae0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

// fix issues with stores and node@20:
...(!testSSR && {
alias: {
"solid-js/store": "solid-js/store/dist/store.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atk I needed to remove it so that both solid-js/store and solid-js/web resolve to the dev runtime version. Instead of the store resolving to prod, and web to dev, causing isDev to be true while the dev features were missing.

@thetarnav thetarnav merged commit 3dcc92e into main Oct 6, 2023
3 checks passed
@thetarnav thetarnav deleted the mutable branch October 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant