-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Solid's createMutable
to new mutable
package
#519
Conversation
|
// fix issues with stores and node@20: | ||
...(!testSSR && { | ||
alias: { | ||
"solid-js/store": "solid-js/store/dist/store.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atk I needed to remove it so that both solid-js/store
and solid-js/web
resolve to the dev runtime version. Instead of the store
resolving to prod, and web
to dev, causing isDev
to be true
while the dev features were missing.
This copies the current implementation of
createMutable
in solid 1.7.12 one-to-one, as the primitive is planned to be removed in core in future releases.As the API is still useful to many people, it will be continued to be developed and maintained here.
The v1 of this package should remain the same as it was in solid, to avoid breaking existing apps, but later it can be extended past the current implementation, as it won't be "held back" by the tight compatibility with
createStore
.createMutable
in solid was some internal logic fromcreateStore
implementation, so using bothcreateMutable
andcreateStore
in your app will mean larger bundle size after the move.