Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize-observer: Use getBoundingClientRect instead of contentRect #509

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

thetarnav
Copy link
Member

resize-observer: Use getBoundingClientRect instead of contentRect to get element size on resize in createElementSize

Fixes #469

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: ddb20f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@solid-primitives/resize-observer Patch
@solid-primitives/bounds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav thetarnav merged commit b6a28e4 into main Sep 8, 2023
3 checks passed
@thetarnav thetarnav deleted the resize-observer-fix branch September 8, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use contentBoxSize and borderBoxSize instead of contentRect in createElementSize
1 participant