disabling custom errors for <0.8.4 backport #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow passing a contract version to the contract builders - modify an existing testcase that was passing two parameters to `funcWith`
this, like many other rules, assumes the same rule visitor is not used for two source files. If that were the case, then visiting an AST with <0.8.4 and then another with no pragma directive would yield false negatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #141
backports work done on protofire/solhint#555 and protofire/solhint#507 by @dbale-altoros
and fix(notreally,onlyonthisrepo)es protofire/solhint#570