Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New Architecture: mobile-wallet-adapter-protocol #1037

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

Michaelsulistio
Copy link
Contributor

@Michaelsulistio Michaelsulistio commented Nov 19, 2024

Backwards compatible Turbo Module for mobile-wallet-adapter-protocol.

Test plan

For each test case, we test newArchEnabled flag both true/false and verify MWA works.

Test cases

  1. Verify working integration for local Example App ✅
  2. Publish beta version on NPM and verify it works in new RN project (test multiple versions <= 0.76.2) ❌
  3. Publish beta version on NPM and verify it works in new Expo project (test multiple versions <=Expo SDK 52) ❌

Don't merge until testing is complete

@Michaelsulistio
Copy link
Contributor Author

Local Import Testing:

For these test, I'm importing mobile-wallet-adapter-protocol and mobile-wallet-adapter-protocol-web3js locally my local repo with newArch changes

React Native Scaffold App

  • Local Import, react-native: 0.71.4, newArchEnabled=false ✅
  • Local Import, react-native: 0.71.4, newArchEnabled=true ✅

Expo Template App

  • Local import, react-native: 0.76.3, Expo SDK 52, newArchEnabled=true ✅
  • Local import, react-native: 0.76.3, Expo SDK 52, newArchEnabled=false ✅

@Funkatronics
Copy link
Contributor

RN Wallet build is failing on CI for an unknown reason. no error is reported. The example app is building locally for me on this branch so we are okay to merge this I will monitor main after merge to see if the build error persists.

@Funkatronics Funkatronics merged commit 91a34c3 into main Nov 26, 2024
1 check failed
@Funkatronics Funkatronics deleted the new-arch-mwa branch November 26, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants