Publish GitHub Pages previews on every PR #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (125)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
11-18-publish_github_pages_previews_on_every_pr
branch
from
c26a6a6 to
080dcbd
Compare
|
steveluscher
force-pushed
the
11-18-publish_github_pages_previews_on_every_pr
branch
21 times, most recently
from
877c695 to
db2f116
Compare
steveluscher
force-pushed
the
11-18-publish_github_pages_previews_on_every_pr
branch
from
db2f116 to
c0a3199
Compare
|
A preview of the GitHub Pages site based on this PR is now available here: |
steveluscher
force-pushed
the
11-18-publish_github_pages_previews_on_every_pr
branch
from
c0a3199 to
38e8d3a
Compare
mcintyre94
approved these changes
Nov 22, 2024
| include-hidden-files: true | ||
| name: ghpages-deploy-artifacts | ||
| path: .ghpages-deploy | ||
| retention-days: 1 |
There was a problem hiding this comment.
Is this going to delete the preview if it's not reviewed within 1 day? I guess we could just run the job again, but is there a downside to making this a bit longer?
There was a problem hiding this comment.
Because all of these CI workflows are stateless, the way that they assemble the GitHub Pages site is by uploading them to a temporary ‘artifacts cache’ that only needs to live for the duration of the CI run. 1 day is actually too long.
Comment on lines
4
to
9
| inputs: | ||
| pr-number: | ||
| type: number | ||
| repository: | ||
| default: 'solana-web3.js' | ||
| type: string |
There was a problem hiding this comment.
I think it'd be useful to add a comment here that the inputs are only used for the REACT_EXAMPLE_APP_BASE_PATH and therefore for new web3js
It took me a while to figure out what's going on when the legacy job calls this without any inputs
Comment on lines
27
to
31
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| include-hidden-files: true | ||
| name: ghpages-deploy-artifacts | ||
| path: .ghpages-deploy |
There was a problem hiding this comment.
Probably just me not knowing stuff, but I'd find a comment here useful that this is uploading for a later deploy to github-pages. Rather than actions/upload-artifact actually being an upload to github pages which is what I first thought was going on.
steveluscher
added
the
automerge
steveluscher
deleted the
11-18-publish_github_pages_previews_on_every_pr
branch
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, every time workflows are run on a PR:
solana-labs.github.io/solana-web3.js-pr-preview/{PR_NUMBER}/This will make it much easier for reviewers to review changes that affect either the example app or the documentation websites.