Fix callx error discrepancy between interpreter and jit
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
changed the title
callx error discrepancy between interpreter and kitcallx error discrepancy between interpreter and jit
Lichtso
reviewed
Nov 11, 2024
Lichtso
reviewed
Nov 11, 2024
Lichtso
reviewed
Nov 11, 2024
Lichtso
reviewed
Nov 11, 2024
Lichtso
reviewed
Nov 18, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
reviewed
Nov 21, 2024
Lichtso
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set a compute budget of N instructions and an invalid
callxis the Nth instruction, the jitter would mistakenly throw aExceededMaximumInstructionserror, even though executingcallxwas still permitted (executing the very next instruction aftercallxis not). This PR patches the jitter to address this issue and fixes the interpreter to correctly count the instructions executed whencallxerrors out.