Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test move binary is parsed correctly by the GoblinParser #555

Closed
wants to merge 2 commits into from

Conversation

ksolana
Copy link

@ksolana ksolana commented Apr 2, 2024

No description provided.

@ksolana ksolana requested review from Lichtso and alessandrod April 2, 2024 06:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (179a0f9) to head (d7835d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   88.34%   89.42%   +1.07%     
==========================================
  Files          24       23       -1     
  Lines       10282     9937     -345     
==========================================
- Hits         9084     8886     -198     
+ Misses       1198     1051     -147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lichtso
Copy link

Lichtso commented Apr 2, 2024

The GoblinParser is deprecated (see #348 and solana-labs/solana#30497).

@ksolana
Copy link
Author

ksolana commented Apr 2, 2024

The GoblinParser is deprecated (see #348 and solana-labs/solana#30497).

is there a doc that shows the difference between their specifications? That might be useful when we start relying on the new parser.

@ksolana ksolana closed this Apr 2, 2024
@Lichtso
Copy link

Lichtso commented Apr 2, 2024

#290 but not all were implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants