Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update disabling of UrlBars buttons #871

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Update disabling of UrlBars buttons #871

merged 5 commits into from
Dec 20, 2024

Conversation

p-malecki
Copy link
Contributor

This PR updates the disabling of buttons in the UrlBar:

  • reload button's option list when project is in devicesNotFound state
  • goBack, goHome and UrlSelect when project is in either devicesNotFound or starting state
Before After
Screen.Recording.2024-12-20.at.16.23.21.mov
Screen.Recording.2024-12-20.at.16.25.15.mov
Screen.Recording.2024-12-20.at.16.27.56.mov
Screen.Recording.2024-12-20.at.16.28.56.mov

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:37pm

filip131311
filip131311 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@filip131311 filip131311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@p-malecki p-malecki merged commit 1fa81b9 into main Dec 20, 2024
4 checks passed
@p-malecki p-malecki deleted the @p-malecki/fix-reload-options-list-disabling branch December 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip131311 filip131311 filip131311 approved these changes

@maciekstosio maciekstosio Awaiting requested review from maciekstosio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-malecki @filip131311