Refactor open preview logic #870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filip131311
reviewed
Dec 20, 2024
| await commands.executeCommand("setContext", "RNIDE.sidePanelIsClosed", false); | ||
|
|
||
| const panelLocation = workspace | ||
| .getConfiguration("RadonIDE") | ||
| .get<PanelLocation>("panelLocation"); | ||
|
|
||
| if (panelLocation !== "tab") { | ||
| SidePanelViewProvider.showView(context, fileName, lineNumber); |
There was a problem hiding this comment.
Why is context not necessery in Side panel while it remains necessary in tabpanel?
There was a problem hiding this comment.
showView doesn't use it at all, so I removed it 💁♂️
From what I quickly went through, SidePanelViewProvider gets context in the constructor and, being a static method, fails gracefully when it isn't provided. I didn't go deeper, as I assume this is outside the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
This PR refactors logic related to opening previews. We were using
showIDEPanelforRNIDE.showPanel/RNIDE.openPanelcommands, the launch preview depended on the existence of thefileNameandlineNumber. The problem is that VSCode passes its arguments there, but instead number in lineNumber we get an object with the panel's id, which triggers this logic always. Thus, I refactored the opening preview to use a separate command.Additionally, startPreview was running even if the project wasn't set up yet, which led to an error that we used
.projectonnull. Now, we open the panel and show a warning in that case.How Has This Been Tested:
Repeat those scenarios for preview both in
tab panelandside panel:Steps:
Expected:
The panel opens without error dialog.
Steps:
Expected:
Confirm that panel opens and there is warning message
Steps:
Expected:
Confirm that preview started
Tested on react-native-76