Remove background color #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's a compromise I'm not too happy with. I agree that when we remove the background the extension blends better with the vscode themes but the buttons, the modals, the dropdowns randomly do not match the rest of the extension. Without the background the whole product feels incoherent, unpolished, and just off. For now, I'd rather have a consistent yet incomplete product (missing themes). I could spend some time to implement this properly in a future release. Related to #729 |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello IDE team 👋
This PR simply removes the background color of the IDE panel and uses the default one provided by the selected theme. This approach feels more natural - in my opinion. Here is a comparison video:
Before
Screen.Recording.2024-12-19.at.22.56.42.mov
After
Screen.Recording.2024-12-19.at.22.57.24.mov
This is just a suggestion. Feel free to close this PR if you don't like the changes - no hard feelings 😄