-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide scrollbar in narrow IDE window with hidden device frame #852
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this work ok when device frame is present and breaks with frameless mode?
I don't agree swipe gesture isn't practical. It is equally practical regardless of how narrow the screen is
This reverts commit 07126c3.
It works with visible device frame, because it covers To keep the Screen.Recording.2024-12-16.at.10.41.25.mov |
ok, but why 415px is the breakpoint here? |
In fact, setting |
This PR addresses the issue of a scrollbar appearing when the IDE window is narrow and the device frame is hidden.
The scrollbar appeared because the
touch-area
for edge swipe gestures extends beyond the phone content width. To fix this,overflow: hidden
is applied for windows narrower than 415px to overrideoverflow: auto
inphone-wrapper
.Screen.Recording.2024-12-13.at.12.28.07.mov
Screen.Recording.2024-12-16.at.10.48.55.mov