Remove hardcoded sys images paths and use newest image for quick device creation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes hardcoded system image paths that were used when user had no simulators created.
As a result, the buttons "Create iPhone" or "Create Android" would do nothing, because we wouldn't be able to find the exact image that was hardcoded.
Now, instead of exepecting some particular image, we select the newest available image both for iOS and Android.
We also change text on the buttons such that we no longer show the exact name of the device. It wasn't helpful to name the device and on some some resolutions it the spinner that appears on the button was causing the longer text to be misplaced.