init

software-mansion · Dec 20, 2024 · 70e7a33 · 70e7a33
1 parent 70b8723
commit 70e7a33
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/packages/vscode-extension/src/project/deviceSession.ts b/packages/vscode-extension/src/project/deviceSession.ts
@@ -316,17 +316,21 @@ export class DeviceSession implements Disposable {
   }
 
   public async changeDeviceSettings(settings: DeviceSettings): Promise<boolean> {
-    this.deviceSettings = settings;
-    if (settings.replaysEnabled && !this.isLaunching) {
-      this.device.enableReplay();
-    } else {
-      this.device.disableReplays();
+    if (this.deviceSettings?.replaysEnabled !== settings.replaysEnabled) {
+      if (settings.replaysEnabled && !this.isLaunching) {
+        this.device.enableReplay();
+      } else {
+        this.device.disableReplays();
+      }
     }
-    if (settings.showTouches && !this.isLaunching) {
-      this.device.showTouches();
-    } else {
-      this.device.hideTouches();
+    if (this.deviceSettings?.showTouches !== settings.showTouches) {
+      if (settings.showTouches && !this.isLaunching) {
+        this.device.showTouches();
+      } else {
+        this.device.hideTouches();
+      }
     }
+    this.deviceSettings = settings;
     return this.device.changeSettings(settings);
   }
 

diff --git a/packages/vscode-extension/src/webview/components/DeviceSettingsDropdown.tsx b/packages/vscode-extension/src/webview/components/DeviceSettingsDropdown.tsx
@@ -103,7 +103,7 @@ function DeviceSettingsDropdown({ children, disabled }: DeviceSettingsDropdownPr
                 defaultValue={[contentSizes.indexOf(deviceSettings.contentSize)]}
                 max={6}
                 step={1}
-                onValueChange={([value]) => {
+                onValueCommit={([value]) => {
                   project.updateDeviceSettings({
                     ...deviceSettings,
                     contentSize: contentSizes[value],