Skip to content

Commit

Permalink
Diagnostics modal - Fix pods installed endless load (#49)
Browse files Browse the repository at this point in the history
Before: 
When an error occurred during pods installation diagnostics modal would
indicate that installation is in progress endlessly.


https://github.com/software-mansion/react-native-ide/assets/159789821/14bbdd28-2be0-4ca9-b049-ac36028f3b55

After: 
Error forces new dependency check.


https://github.com/software-mansion/react-native-ide/assets/159789821/9e574055-2aae-4dac-b96a-a4137878981c

Fixes: #39

---------

Co-authored-by: Filip Andrzej Kaminski <[email protected]>
  • Loading branch information
filip131311 and Filip Andrzej Kaminski authored Mar 29, 2024
1 parent e98d79c commit 25aed84
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,12 @@ export class DependencyInstaller implements Disposable {
this.webview.postMessage({
command: "installingPods",
});

await installIOSDependencies(getAppRootFolder(), false);
Logger.debug("Finished installing pods!");
try {
await installIOSDependencies(getAppRootFolder(), false);
Logger.debug("Finished installing pods!");
} catch (error) {
Logger.error("Install Pods:", error);
}
await this.dependencyChecker.checkPodsInstalled();
}
}
Expand Down

0 comments on commit 25aed84

Please sign in to comment.