Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sofa.GL] Fix OglModel crash when texture file is not found #5182

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[Sofa.GL] Fix OglModel crash when texture file is not found #5182

merged 1 commit into from
Dec 27, 2024
+24 −19

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Dec 26, 2024

If the Data texturename is given but the file is not found, SOFA just crashes at start.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Dec 26, 2024
@fredroy
Copy link
Contributor

fredroy commented Dec 27, 2024

[ci-build][with-all-tests]

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 27, 2024
@fredroy fredroy merged commit 07ce419 into sofa-framework:master Dec 27, 2024
19 of 22 checks passed
@epernod epernod deleted the fix_texture branch December 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epernod @fredroy