Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Fix additional warnings #5180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[all] Fix additional warnings #5180

wants to merge 1 commit into from

Conversation

hugtalbot
Copy link
Contributor

🎁 🎄 🎁

🧹 ⚠️🧹

🎁 🎄 🎁

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code and removed pr: clean Cleaning the code pr: fix Fix a bug labels Dec 26, 2024
epernod
epernod requested changes Dec 26, 2024
View reviewed changes
Sofa/Component/Collision/Response/Mapper/src/sofa/component/collision/response/mapper/init.cpp
@@ -48,7 +48,7 @@ const char* getModuleVersion()
return MODULE_VERSION;
}

void registerObjects(sofa::core::ObjectFactory* factory)
void registerObjects(sofa::core::ObjectFactory* /*factory*/)
{
// this library does not register any component in the Factory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// this library does not register any component in the Factory
// this library does not register any component in the Factory
SOFA_UNUSED(factory);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod requested changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugtalbot @epernod