Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simulation] In-place creation of mechanical visitors #5154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alxbilger
Copy link
Contributor

Modern and flexible creation of the usual mechanical visitors at the call site. It uses the function makeMechanicalVisitor.
An example of use.

Pros:

  • No more back-and-forth between the call site and the visitor file. The intention can be read clearly at the call site.
  • Dozens of visitor files can be removed

Cons:

  • A bit of template meta-programming
  • Some ugly macros
  • More code at the call site (but it's so much clearer so it's not a con😄 )

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Dec 9, 2024
@alxbilger alxbilger added this to the v25.06 milestone Dec 9, 2024
@alxbilger alxbilger mentioned this pull request Dec 9, 2024
5 tasks
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant