Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring] Add warning when user tries to override MeshSpringForcefield indices #5136

Merged
merged 6 commits into from
Dec 8, 2024
Merged

[Spring] Add warning when user tries to override MeshSpringForcefield indices #5136

merged 6 commits into from
Dec 8, 2024

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Nov 21, 2024

Following issue #5135. Add warning when user tries to overide MeshSpringForecefield indices. This mechanism was removed with the pr #4649.

Anyway, it made no sens to override the indices of the MeshSpringForceField, in such case the user should use the SpringForceField.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 21, 2024
@bakpaul bakpaul mentioned this pull request Nov 21, 2024
Closed
@bakpaul bakpaul changed the title [Spring] Add warning when user tries to overide MeshSpringForecefield indices [Spring] Add warning when user tries to override MeshSpringForcefield indices Nov 21, 2024
@bakpaul bakpaul added this to the v24.12 milestone Dec 2, 2024
@bakpaul @hugtalbot
Update Sofa/Component/SolidMechanics/Spring/src/sofa/component/solidm…
4598a35 
…echanics/spring/MeshSpringForceField.inl

Co-authored-by: Hugo <[email protected]>
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 6, 2024
@hugtalbot hugtalbot added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Dec 8, 2024
@hugtalbot hugtalbot merged commit 539b6be into sofa-framework:master Dec 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@bakpaul @hugtalbot