-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Allow different gravity vectors in Nodes #4876
base: master
Are you sure you want to change the base?
Conversation
[ci-build][with-all-tests] |
Interesting change @alxbilger |
Tested and approved 👍 What do you think @alxbilger about setting gravity to "0 0 0" as default value? |
I think it will break a lot of scenes |
I also think about creating a graph link instead of a simple copy: if (!worldGravity_.isSet())
{
worldGravity_.setParent(&c); ///< Gravity IN THE WORLD COORDINATE SYSTEM.
} What do you think? |
I like it baby 🚒 🔥
🤔 why would you do that? I am unsure about side effect |
why @alxbilger |
So that it can update if its parent has changed |
To be noted, this change would only work in XML : SimpleAPI or Python do not change the "isSet" property as does the XML. I investigate on this currently |
If #4911 is solved, then #4910 could replace this PR @alxbilger |
@hugtalbot, isSet is switched to "true" at first value change (eg: any begin/write edit). Can you explain a bit what kind of behavior should be expected ? |
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if