Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MatrixAccumulator] adds 6x6 matrix handling #4247

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

EulalieCoevoet
Copy link
Contributor

Needed for sofa-framework/BeamAdapter#115


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Oct 20, 2023
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the support of 6x6 matrices in DerivativeMatrix::DerivativeElement. Right now, it uses the templated method which calls matAdd (also template). But if you add

void operator+=(const sofa::type::Mat<6, 6, float> & value) const { mat->add(row, col, value); }
void operator+=(const sofa::type::Mat<6, 6, double>& value) const { mat->add(row, col, value); }

it will call the add method you just introduced

@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@alxbilger alxbilger merged commit 54aba25 into sofa-framework:master Oct 23, 2023
2 checks passed
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants