Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Propose a new gravity API #2988

Closed

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented May 29, 2022

This pull request aims at making the gravity clearly appearing in object nodes as a GravityForceField.
Old way to define gravity still works and is not deprecated.

Main changes:

  • By implementing this, the Mass is not inheriting from ForceField anymore.
  • The optional mechanism of a separate gravity and the Gravity class are also deprecated.
  • Default gravity is now 0 (therefore some scenes might fail and need an update)

The GravityForceField can:

  • either be manually added by the user in the node
  • or the gravity can still be globally defined in the root node which will create the automatic creation of a GravityForceField for each mass in the graph

Fix: #2683

[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/305]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/56]
[ci-depends-on https://github.com/sofa-framework/ci/pull/18]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code pr: clean Cleaning the code pr: highlighted in next release Highlight this contribution in the notes of the upcoming release STC#13 Tasks for STC#13 coding sprint labels May 29, 2022
@hugtalbot hugtalbot added NG3: new-archi See https://github.com/sofa-framework/sofa/issues/1527 pr: dev meeting topic PR to be discussed in sofa-dev meeting pr: breaking Change possibly inducing a compilation error and removed NG3: new-archi See https://github.com/sofa-framework/sofa/issues/1527 labels May 29, 2022
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added this to the v22.12 milestone May 29, 2022
@hugtalbot hugtalbot removed the pr: dev meeting topic PR to be discussed in sofa-dev meeting label Nov 2, 2022
@hugtalbot hugtalbot modified the milestones: v22.12, v23.06 Dec 5, 2022
@sofabot
Copy link
Collaborator

sofabot commented Feb 24, 2023

[ci-depends-on] detected during build #16.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2023

[ci-depends-on] detected during build #17.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

What was written above (hidden by GH):


TODO:

  • test when a node is added

One issue remains in my tests :

  • simulation starting without gravity, and then gravity is added
  • mass added using python, since no init, the link in GravityForceField to the local mass is no performed

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2023

[ci-depends-on] detected during build #18.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2023

[ci-depends-on] detected during build #19.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2023

[ci-depends-on] detected during build #20.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2023

[ci-depends-on] detected during build #21.

To unlock the merge button, you must

@fredroy
Copy link
Contributor

fredroy commented Feb 27, 2023

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2023

[ci-depends-on] detected during build #22.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 27, 2023

[ci-depends-on] detected during build #23.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 28, 2023

[ci-depends-on] detected during build #24.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Feb 28, 2023

[ci-depends-on] detected during build #25.

To unlock the merge button, you must

@hugtalbot hugtalbot added STC#15 Tasks for STC#15 coding sprint and removed STC#14 Tasks for STC#14 coding sprint labels Mar 1, 2023
@hugtalbot
Copy link
Contributor Author

Not enough convincing arguments to bring such a breaking feature into SOFA
Let's discuss and possibly close it at next STC#15

@hugtalbot hugtalbot added issue: discussion Open topic of discussion and removed pr: status to review To notify reviewers to review this pull-request labels Mar 2, 2023
@hugtalbot hugtalbot removed this from the v23.06 milestone May 31, 2023
@hugtalbot hugtalbot closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: discussion Open topic of discussion pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: highlighted in next release Highlight this contribution in the notes of the upcoming release refactoring Refactor code STC#15 Tasks for STC#15 coding sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dedicated gravity forcefield
5 participants