-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Propose a new gravity API #2988
[All] Propose a new gravity API #2988
Conversation
…f Mass, clean of OdeSolver
[ci-build][with-all-tests] |
Sofa/framework/Core/src/sofa/core/behavior/GravityForceField.inl
Outdated
Show resolved
Hide resolved
[ci-depends-on] detected during build #16. To unlock the merge button, you must
|
[ci-depends-on] detected during build #17. To unlock the merge button, you must
|
What was written above (hidden by GH): TODO:
One issue remains in my tests :
|
[ci-depends-on] detected during build #18. To unlock the merge button, you must
|
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #19. To unlock the merge button, you must
|
[ci-depends-on] detected during build #20. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #21. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #22. To unlock the merge button, you must
|
[ci-depends-on] detected during build #23. To unlock the merge button, you must
|
[ci-depends-on] detected during build #24. To unlock the merge button, you must
|
[ci-depends-on] detected during build #25. To unlock the merge button, you must
|
Not enough convincing arguments to bring such a breaking feature into SOFA |
This pull request aims at making the gravity clearly appearing in object nodes as a GravityForceField.
Old way to define gravity still works and is not deprecated.
Main changes:
The GravityForceField can:
Fix: #2683
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/305]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/56]
[ci-depends-on https://github.com/sofa-framework/ci/pull/18]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if