Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubgen autogeneration #453

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Sep 19, 2024

At first I wanted to make it auto generated in the CMake project, to have a well integrated workflow in the build. I tried in many ways :

  1. Tried to do it during the build (see first commit). But because ninja offers no guaranty over the dependency effective termination (see https://cmake.org/cmake/help/latest/command/add_dependencies.html#command:add_dependencies) it doesn't work.
  2. Tried to do it through a add_custom_command but it isn't possible because the targets SofaPython3 and Bindings are Interfaces.
  3. Also tried to do it during the install process which is a nightmare because the installation order isn't ordered.

So back to the weak solution, a script that needs to be run by hands. I'll really enjoy adding it to Jenkins...

@fredroy fredroy force-pushed the add_stubgen_autogeneration branch from 8653620 to 13ba8e9 Compare November 6, 2024 09:45
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the script generate_stubs to be written in Python. It would more readable and cross-platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants