Apply new factory registration mechanism + refresh #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: clean
pr: new feature
pr: status to review
fredroy
force-pushed
the
register_beamadapter_and_refresh
branch
from
89056f4 to
397fa9b
Compare
hugtalbot
reviewed
Dec 27, 2024
|
|
||
| namespace beamadapter |
There was a problem hiding this comment.
Hey @fredroy
Could you explain why
- the
template class SOFA_BEAMADAPTER_API BeamInterpolation<sofa::defaulttype::Rigid3Types>;should be in one namespace - while the
registerBeamInterpolation()is in another namespace ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
+ :
A future PR should uniform/clean/make consistent the namespaces, it is a real mess