Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize SofaCUDA #133

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Initialize SofaCUDA #133

merged 1 commit into from
Feb 9, 2024

Conversation

alxbilger
Copy link
Contributor

Based on #132 and requires sofa-framework/sofa#4453. Only the last commit is important.

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Jan 23, 2024
epernod
epernod requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a little mess between:
BeamAdapter.CUDA/
and
BeamAdapter/CUDA/

@alxbilger
Copy link
Contributor Author

@epernod you were right, I did not rebase. It should be ok now

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 9, 2024
@epernod epernod merged commit 3dc37e3 into sofa-framework:master Feb 9, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxbilger @epernod