-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RodSectionMaterial classes to be used in WireRestShape #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wire section and delegate the interpolation param to this class
Co-authored-by: Frederick Roy <[email protected]>
epernod
added
pr: new feature
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 19, 2023
epernod
changed the title
Rod sections
Add RodSectionMaterial classes to be used in WireRestShape
Oct 19, 2023
fredroy
approved these changes
Oct 20, 2023
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split PR #65 into several to solve the problem of divergence in the regression tests.
In this PR we only add the new classes without using it in the WireRestShape:
Add new set of classes which hold the mechanical property and the topology (visual and collision) description of a section of the Rod/Wire.