[REVIEW] - udhcp.user uci commit only new hostnames

[ruebenramirez]

Description of PR

Instead of always committing a provided hostname, only commit new hostnames, where the new hostname doesn't match the current hostname.

Resolves #442

Previous Behavior

Any time a hostname value was available, udhcp.user would uci commit the new hostname.

New Behavior

udhcp.user will only uci commit the hostname if it is different than the current hostname.

Tests

(need some help here)

• test against AP hardware (monitor for uci commits)
• provide the same hostname change to the device
• provide a new hostname to the device

[sarcasticadmin]

@ruebenramirez I think this all makes sense, the one suggestion from @kylerisse for making a compound if seems like its worthwhile.

Regarding testing this, I can circle back with you once you have time about getting it running through the real hardware CI via gitlab.

[ruebenramirez]

@ruebenramirez I think this all makes sense, the one suggestion from @kylerisse for making a compound if seems like its worthwhile.

Regarding testing this, I can circle back with you once you have time about getting it running through the real hardware CI via gitlab.

Compound conditional is in place now. I'm looking forward to learning more about the hardware testing process.

[kylerisse]

@ruebenramirez I think this all makes sense, the one suggestion from @kylerisse for making a compound if seems like its worthwhile.
Regarding testing this, I can circle back with you once you have time about getting it running through the real hardware CI via gitlab.

Compound conditional is in place now. I'm looking forward to learning more about the hardware testing process.

https://github.com/socallinuxexpo/scale-network/actions/runs/11266376404/job/31329957560?pr=785 ci choking on script @ruebenramirez . I think you just need to wrap the entire compound if in another set of [ ]
or now that I look further, maybe it's because the goldens needs to be updated also. This gets me all the time also.

• https://github.com/socallinuxexpo/scale-network/blob/master/tests/unit/openwrt/golden/ar71xx/etc/udhcpc.user
• https://github.com/socallinuxexpo/scale-network/blob/master/tests/unit/openwrt/golden/ipq806x/etc/udhcpc.user

[ruebenramirez]

Derp! Thanks @kylerisse! Those should all be accounted for now. If we want the extra [ ]'s I can throw them in, I just didn't see them in other compound conditionals. Maybe I need to look harder though? ;)

[kylerisse]

Derp! Thanks @kylerisse! Those should all be accounted for now. If we want the extra [ ]'s I can throw them in, I just didn't see them in other compound conditionals. Maybe I need to look harder though? ;)

Not your derp. It's a weird thing we do. In this case it was stopping at nix build -L .#checks.x86_64-linux.openwrt-golden. I believe we can add you to the repo so that your checks run automatically. @sarcasticadmin has to put in a request with TPTB. CI passes now, I think we just wait for you guys to do hardware testing. For the double [ ] that's just another case of me typing before thinking... And thank you for fixing up the commit!

[sarcasticadmin]

Thanks @ruebenramirez for all the fixups and @kylerisse for your feedback. I request rueben be add to the @socallinuxexpo/tech so that should make this process and future openwrt testing easier 🙂

@ruebenramirez and I will sync up on testing this on real hardware before we merge

[ruebenramirez]

Hey look at me!

I confirmed I can trigger workflows now too :)