feat: OSS via LS [HEAD-78] #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adds new LS based OssService class * chore: read OSS settings for LS initialisation options * chore: add unit tests for new OssService --------- Co-authored-by: Peter Schäfer <[email protected]>
* refactor: rename and move ossSuggestionWebviewProviderLanguageServer * feat: add new OSS (LS) panel in Snyk UI * feat: configure new views and activation events for LS OSS treeview * refactor: OSS messages for LS implementation; OssIssueCommandArgLanguerServer type * refactor: getIssueRange abstract method to allow undefined * feat: implement OSS vulnerability tree via LS class * feat: configure extension.ts to show LS OSS vulnerability tree view * feat: update issue types to support LS OSS issue command args * refactor: getOpenIssueCommand abstract method to support LS OSS implementations * feat: implement initial LS OSS treeview
* chore: introduce observerable in ProductService * feat: enable LS based Vulnerability Count Service * fix: creating subject * chore: introduce static getOssIssueArgCommand() * chore: adapt vuln count code action provider * chore: remove dependency to old OSSService * fix: linter & cleanup * chore: adapt test to use LS versions of classes * chore: delete now obsolote classes * fix: duplicate diagnostics message * fix: use strict equal * chore: convert severities explicitely * fix: typo
* docs: update instructions for contribution to include `npm run build` Signed-off-by: Bastian Doetsch <[email protected]> * chore: use ls based oss service in cmdcontroller * chore: move convertion of Issue to OssVulnerability * chore: adapt test * chore: delete vulnerabilityCountCodeActionProviderLS class as LS handles CodeActions now * chore: delete vulnerabilityCountHoverProvider class as LS handles hovers now * chore: clean up codeaction/hovers where they are not needed anymore * fix: linting * check license data if undefined * chore: display received details html * chore: initial version taking html from ls * chore: inject learn icon * chore: inject nonce and cspsource * fix: linter --------- Signed-off-by: Bastian Doetsch <[email protected]> Co-authored-by: Bastian Doetsch <[email protected]> Co-authored-by: Jason Luong <[email protected]>
j-luong
force-pushed
the
feat/HEAD-78_oss_via_ls
branch
from
ad25056 to
eff4ad8
Compare
j-luong
force-pushed
the
feat/HEAD-78_oss_via_ls
branch
from
5dd4c5b to
e908c94
Compare
j-luong
force-pushed
the
feat/HEAD-78_oss_via_ls
branch
from
e908c94 to
033be34
Compare
* chore: do not show vuln count text if vuln count is 0 * chore: updated changelog
bastiandoetsch
temporarily deployed
to
Preview
GitHub Actions
Inactive
Signed-off-by: Bastian Doetsch <[email protected]>
bastiandoetsch
temporarily deployed
to
Preview
GitHub Actions
Inactive
Signed-off-by: Bastian Doetsch <[email protected]>
bastiandoetsch
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!