fix: security upgrade axios from 0.27.2 to 1.6.0 [HEAD-1036] #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AXIOS-6032459
This change ensures compatibility with Axios 1.x's AxiosRequestHeaders type and resolves TypeScript type mismatch issues.
cat2608
force-pushed
the
snyk-fix-0df67984f09f7a05869d0c2826b55c00
branch
from
3ebe03f to
9fc9cda
Compare
cat2608
reviewed
Dec 1, 2023
| req.headers = { | ||
| ...req.headers, | ||
| Authorization: `token ${token}`, | ||
| } as { [header: string]: string }; | ||
|
|
||
| req.headers['Authorization'] = `token ${token}`; |
There was a problem hiding this comment.
Change needed due to Axios upgrade. This change sets the Authorization header individually instead of overwriting the entire headers object.
There was a problem hiding this comment.
suggestion: if this is the only place where axios is used, we may be able to get rid of the functionality entirely. I think advisor is a remnant of an incomplete contribution, which we need to remove anyway. Have you found any location where it is used in the extension right now?
There was a problem hiding this comment.
@bastiandoetsch after some research, I can see that this feature was completed here. I'm not sure why it's not a toggle in the settings of Snyk. To be able to see it, we enabled it with
"snyk.features.preview": {
"advisor": true
}
cat2608
changed the title
bastiandoetsch
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.1
SNYK-JS-AXIOS-6032459
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: axios
The new version differs by 250 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Request Forgery (CSRF)