feat: create new ossService #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-luong
changed the title
PeterSchafer
approved these changes
Oct 26, 2023
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
* feat: adds new LS based OssService class * chore: read OSS settings for LS initialisation options * chore: add unit tests for new OssService --------- Co-authored-by: Peter Schäfer <[email protected]>
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
* feat: adds new LS based OssService class * chore: read OSS settings for LS initialisation options * chore: add unit tests for new OssService --------- Co-authored-by: Peter Schäfer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
OssServiceclass which uses Language Server as it's underlying datasource instead of the CLI. The new class is not currently integrated with any views.Checklist