Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: settings sections #335

Merged
merged 16 commits into from
Dec 20, 2024
Merged

feat: settings sections #335

merged 16 commits into from
Dec 20, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Dec 16, 2024 •
edited
Loading

Description

  • Decouple storageProvider form Options.
  • Persistence is managed by SnykOptionsManager.
  • Different Dialog pages for each settings section.
  • Persist settings on "Ok" btn click.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • CHANGELOG.md updated

Screenshots / GIFs

image
image
image
image
image
image

@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 11:01 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 11:01 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 11:01 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 12:44 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 12:44 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ force-pushed the feat/settings-sections branch from ebcb74f to f1d42b4 Compare December 16, 2024 12:44
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 12:44 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 12:44 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 16, 2024 12:44 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ force-pushed the feat/settings-sections branch from f1d42b4 to fe3542f Compare December 17, 2024 13:29
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 13:29 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 13:29 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 13:29 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 17:56 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 17:57 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 18:13 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 18:13 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 18:45 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 17, 2024 18:45 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 09:02 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 09:03 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 10:39 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 10:39 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 10:39 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 15:24 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 15:24 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 15:24 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ enabled auto-merge (squash) December 20, 2024 15:25
@ShawkyZ ShawkyZ disabled auto-merge December 20, 2024 15:26
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 18:22 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 18:22 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 18:23 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 18:23 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs December 20, 2024 18:23 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ merged commit 6794ceb into main Dec 20, 2024
12 checks passed
@ShawkyZ ShawkyZ deleted the feat/settings-sections branch December 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @bastiandoetsch