fix: include pkg version in pkgIdProvenance label

snyk · Dec 18, 2024 · de1fc50 · de1fc50
1 parent 5bbc02b
commit de1fc50
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/poetry-dep-graph-builder.ts b/lib/poetry-dep-graph-builder.ts
@@ -63,7 +63,7 @@ function addDependenciesForPkg(
     scope: dependency.isDev ? 'dev' : 'prod',
   };
   if (pkg.name != pkgName) {
-    labels.pkgIdProvenance = pkgName;
+    labels.pkgIdProvenance = `${pkgName}@${pkg.version}`;
   }
   builder
     .addPkgNode(pkgInfo, pkg.name, {

diff --git a/test/fixtures/index.test.ts b/test/fixtures/index.test.ts
@@ -45,7 +45,7 @@ describe('buildDepGraph', () => {
       })
       .connectDep(depGraphBuilder.rootNodeId, 'jinja2')
       .addPkgNode({ name: 'markupsafe', version: '1.1.1' }, 'markupsafe', {
-        labels: { scope: 'prod', pkgIdProvenance: 'MarkupSafe' },
+        labels: { scope: 'prod', pkgIdProvenance: 'MarkupSafe@1.1.1' },
       })
       .connectDep('jinja2', 'markupsafe')
       .build();
@@ -68,7 +68,7 @@ describe('buildDepGraph', () => {
         })
         .connectDep(depGraphBuilder.rootNodeId, 'six')
         .addPkgNode({ name: 'isodd', version: '0.1.2' }, 'isodd', {
-          labels: { scope: 'dev', pkgIdProvenance: 'isOdd' },
+          labels: { scope: 'dev', pkgIdProvenance: 'isOdd@0.1.2' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'isodd')
         .build();
@@ -108,7 +108,7 @@ describe('buildDepGraph', () => {
         })
         .connectDep(depGraphBuilder.rootNodeId, 'six')
         .addPkgNode({ name: 'isodd', version: '0.1.2' }, 'isodd', {
-          labels: { scope: 'dev', pkgIdProvenance: 'isOdd' },
+          labels: { scope: 'dev', pkgIdProvenance: 'isOdd@0.1.2' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'isodd')
         .build();
@@ -148,7 +148,7 @@ describe('buildDepGraph', () => {
         })
         .connectDep(depGraphBuilder.rootNodeId, 'six')
         .addPkgNode({ name: 'isodd', version: '0.1.2' }, 'isodd', {
-          labels: { scope: 'dev', pkgIdProvenance: 'isOdd' },
+          labels: { scope: 'dev', pkgIdProvenance: 'isOdd@0.1.2' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'isodd')
         .addPkgNode({ name: 'simple-enum', version: '0.0.6' }, 'simple-enum', {
@@ -192,15 +192,15 @@ describe('buildDepGraph', () => {
         })
         .connectDep(depGraphBuilder.rootNodeId, 'six')
         .addPkgNode({ name: 'isodd', version: '0.1.2' }, 'isodd', {
-          labels: { scope: 'dev', pkgIdProvenance: 'isOdd' },
+          labels: { scope: 'dev', pkgIdProvenance: 'isOdd@0.1.2' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'isodd')
         .addPkgNode({ name: 'simple-enum', version: '0.0.6' }, 'simple-enum', {
           labels: { scope: 'dev' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'simple-enum')
         .addPkgNode({ name: 'whattype', version: '0.0.1' }, 'whattype', {
-          labels: { scope: 'dev', pkgIdProvenance: 'whatType' },
+          labels: { scope: 'dev', pkgIdProvenance: 'whatType@0.0.1' },
         })
         .connectDep(depGraphBuilder.rootNodeId, 'whattype')
         .build();