fix: add iac ignore button [IDE-683] #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/kotlin/io/snyk/plugin/ui/toolwindow/panels/JCEFDescriptionPanel.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/snyk/plugin/ui/toolwindow/panels/JCEFDescriptionPanel.kt
Outdated
Show resolved
Hide resolved
bastiandoetsch
approved these changes
Nov 14, 2024
DariusZdroba
commented
Nov 15, 2024
| @@ -209,7 +233,6 @@ class SuggestionDescriptionPanelFromLS( | |||
|
|
|||
| private fun getCustomScript(): String { | |||
| return """ | |||
| (function () { | |||
There was a problem hiding this comment.
When extracting the script to migrate it to Language Server, we need acces to some variables which are locked in the scope of this self invoked function and can't be accessed outside,
we can have all the logic encapsulated in a self invoked function in Language Server, that would require some minimal changes to all IDE's that inject scripts.
DariusZdroba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides the logic to ignore an IaC finding for a specific file in the IntelliJ plugin, the ignore button is implicitly hidden and set to show in IntelliJ only.
The HTML panel that comes from the Language Server receives dynamic attributes with injected values such as the
pathandIssue.ID, these are extracted in a custom JS script and called through a callback when clicking ignore button , this triggers theIgnoreHandler.In the
IgnoreHandlertheIgnoreServiceis called which calls calls the CLI through the LS Wrapper to execute thesnyk ignorecommand on the specified params.This path and issue id comes injected in the HTML template which comes from Snyk LS.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!