feat: source IaC results from LS, make progresses & scans cancelable [IDE-630] #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/io/snyk/plugin/ui/toolwindow/panels/JCEFDescriptionPanel.kt # src/main/resources/META-INF/plugin.xml
# Conflicts: # CHANGELOG.md
bastiandoetsch
changed the title
ShawkyZ
reviewed
Oct 1, 2024
|
|
||
| private fun cancelProgress(token: String) { | ||
| try { | ||
| progresses[token]?.cancel() |
There was a problem hiding this comment.
am wondering if we need a mutex here
There was a problem hiding this comment.
progresses is a concurrentMap - so we don't
ShawkyZ
reviewed
Oct 1, 2024
| @@ -68,7 +68,6 @@ class BranchChooserComboBoxDialog(val project: Project) : DialogWrapper(true) { | |||
| } | |||
| runAsync { | |||
| LanguageServerWrapper.getInstance().updateConfiguration() | |||
| LanguageServerWrapper.getInstance().sendScanCommand(project) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
will LS trigger a scan here on config change? or is it a behavior we don't want atm?
There was a problem hiding this comment.
I think, updateConfiguration() already triggers a scan.
ShawkyZ
reviewed
Oct 1, 2024
ShawkyZ
reviewed
Oct 1, 2024
# Conflicts: # src/main/kotlin/snyk/common/lsp/SnykLanguageClient.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!