feat: add vulnerability count #613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
changed the title
bastiandoetsch
commented
Sep 14, 2024
| @@ -68,7 +68,6 @@ class BranchChooserComboBoxDialog(val project: Project) : DialogWrapper(true) { | |||
| } | |||
| runAsync { | |||
| LanguageServerWrapper.getInstance().updateConfiguration() | |||
| LanguageServerWrapper.getInstance().sendScanCommand(project) | |||
There was a problem hiding this comment.
update configuration already runs a scan after update
bastiandoetsch
commented
Sep 14, 2024
| @@ -427,6 +428,7 @@ fun Project.getContentRootPaths(): SortedSet<Path> { | |||
| } | |||
|
|
|||
| fun Project.getContentRootVirtualFiles(): Set<VirtualFile> { | |||
| if (this.isDisposed) return emptySet() | |||
There was a problem hiding this comment.
fixes exception during disposal of resources
bastiandoetsch
commented
Sep 14, 2024
Comment on lines
+33
to
+45
| private fun getBrowser(): Pair<JBCefClient, JBCefBrowser> { | ||
| if (jbCefPair != null) { | ||
| return jbCefPair | ||
| } | ||
| val cefClient = JBCefApp.getInstance().createClient() | ||
| cefClient.setProperty("JS_QUERY_POOL_SIZE", 1) | ||
| val jbCefBrowser = | ||
| JBCefBrowserBuilder().setClient(cefClient).setEnableOpenDevToolsMenuItem(false) | ||
| .setMouseWheelEventEnable(true).build() | ||
| jbCefBrowser.setOpenLinksInExternalBrowser(true) | ||
| val jbCefPair = Pair(cefClient, jbCefBrowser) | ||
| return jbCefPair | ||
| } |
There was a problem hiding this comment.
initialize the browser component only once, this prevents flickering and is more performant.
|
Merged it into the IaC PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs