Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only create one annotation per finding, not one per fix #604

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

bastiandoetsch
Copy link
Collaborator

@bastiandoetsch bastiandoetsch commented Sep 7, 2024

Description

Previously, each fix was created as an annotation. This cluttered the hover/tooltip. Now only the issue is created, and fixes are added to that single line of text.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Before:
image
image

After:
image
image

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner September 7, 2024 10:28
@bastiandoetsch bastiandoetsch marked this pull request as draft September 7, 2024 10:32
@bastiandoetsch bastiandoetsch marked this pull request as ready for review September 7, 2024 10:44
call language server for code actions only once per range, do pre-sort before UI thread
@bastiandoetsch bastiandoetsch changed the title fix: only create one annotations and associate several fixes with it fix: only create one annotation per finding, not one per fix Sep 8, 2024
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bastiandoetsch bastiandoetsch merged commit 7bda3b1 into master Sep 9, 2024
9 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/cluster-fixes-on-one-annotation branch September 9, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants