feat: add net new issues setting to settings page [IDE-598] #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
force-pushed
the
feat/add_delta_dropbox
branch
from
e2eef2c to
8a482cb
Compare
src/main/kotlin/io/snyk/plugin/settings/SnykProjectSettingsConfigurable.kt
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/add_delta_dropbox
branch
from
88d09bb to
cd86f7f
Compare
src/main/kotlin/io/snyk/plugin/settings/SnykProjectSettingsConfigurable.kt
Outdated
Show resolved
Hide resolved
acke
force-pushed
the
feat/add_delta_dropbox
branch
from
cd86f7f to
0b97f76
Compare
cat2608
changed the title
| @@ -459,6 +463,61 @@ class SnykSettingsDialog( | |||
| ), | |||
| ) | |||
|
|
|||
| val netNewIssuesPanel = JPanel(UIGridLayoutManager(2, 4, JBUI.emptyInsets(), -1, -1)) | |||
| //netNewIssuesPanel.border = IdeBorderFactory.createTitledBorder("All issues Vs Net new issues") | |||
There was a problem hiding this comment.
Please remove the commented text
| @@ -756,5 +816,7 @@ class SnykSettingsDialog( | |||
|
|
|||
| fun getCliReleaseChannel(): String = cliReleaseChannelDropDown.selectedItem as String | |||
|
|
|||
| fun isNetNewIssuesSelected(): String = netNewIssuesDropDown.selectedItem as String | |||
There was a problem hiding this comment.
shouldn't that be getNetNewIssuesSelection()? Is.. are usually returnin boolean values.
| @@ -405,6 +406,7 @@ class LanguageServerWrapper( | |||
| integrationVersion = pluginInfo.integrationVersion, | |||
| authenticationMethod = authMethod, | |||
| enableSnykOSSQuickFixCodeActions = "true", | |||
| enableDeltaFindings = ps.isDeltaFindingsEnabled(), | |||
There was a problem hiding this comment.
This line is unnecessary, as the default is already set when instantiating the settings class. As the default is exactly the same, this line is redundant.
bastiandoetsch
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new setting on the settings page that allows the user to choose to show All issues as scan results or just the Net new issues from a delta scan.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!