Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor and unit test #579

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

acke
Copy link
Contributor

@acke acke commented Aug 26, 2024

Description

Small refactor and added unit test.

Checklist

  • Tests added and all succeed
  • Linted

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch
Copy link
Collaborator

Let's wait for #549 - there's some fixes & conflicts would occur.

@acke acke force-pushed the chore/diagnostic-issue-model-tests branch 2 times, most recently from 1177b77 to 9ad980c Compare August 28, 2024 11:14
@acke acke force-pushed the chore/diagnostic-issue-model-tests branch from 9ad980c to 5d72eaf Compare September 30, 2024 08:01
@acke acke marked this pull request as ready for review September 30, 2024 08:42
@acke acke requested a review from a team as a code owner September 30, 2024 08:42
@acke acke enabled auto-merge (squash) September 30, 2024 08:42
@bastiandoetsch bastiandoetsch merged commit fd79a41 into master Oct 2, 2024
9 checks passed
@bastiandoetsch bastiandoetsch deleted the chore/diagnostic-issue-model-tests branch October 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants