feat: load html for oss in ls [IDE-285] #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/html-oss-intellij
branch
2 times, most recently
from
bddd3b1 to
154f250
Compare
| fun generate(jbCefBrowser: JBCefBrowserBase): CefLoadHandlerAdapter { | ||
| val isDarkTheme = EditorColorsManager.getInstance().isDarkEditor | ||
| val isHighContrast = | ||
| EditorColorsManager.getInstance().globalScheme.name.contains("High contrast", ignoreCase = true) |
There was a problem hiding this comment.
Wondering: should we also set the other font? It looks like the font is different in "native" and "html", and that maybe is due to not taking the theme font?
There was a problem hiding this comment.
We could, but what would be the point of it? Is it to make the change more gradual once we enable this feature?
bastiandoetsch
approved these changes
Jul 10, 2024
teodora-sandu
force-pushed
the
feat/html-oss-intellij
branch
from
154f250 to
e522ac8
Compare
teodora-sandu
force-pushed
the
feat/html-oss-intellij
branch
from
e522ac8 to
00392c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some styling so that the new HTML panel and the native panel look more or less the same. The only noticeable differences are:
Detailed pathschanged fromFixtoRemediationRefactors the code a bit too so that we can re-use more of it for both Snyk Code and Snyk OSS.
Needs snyk/cli#5356 for testing.
Checklist
Screenshots / GIFs
Native:
HTML:
