feat: inject custom styling [IDE-240] #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/IDE-240-consistent-styles
branch
2 times, most recently
from
dfa0fa3 to
1be34e1
Compare
cat2608
reviewed
May 31, 2024
|
|
||
| .example-line.removed { | ||
| background-color: var(--example-line-removed-color); | ||
| } |
There was a problem hiding this comment.
Why did we need to use a SASS file? I thought SASS is needed when we need things like nesting or mixins or other SASS magic ✨
There was a problem hiding this comment.
Mostly because we use SASS in VSCode so I wanted to be as consistent as possible across the two, but also because there are more features available in SASS (like you said) and in the future we will have more than Snyk Code styling but still want to share stylesheets or colours across Snyk OSS, Snyk IaC, and Snyk Container
teodora-sandu
commented
May 31, 2024
| @@ -108,7 +108,7 @@ class LanguageServerWrapper( | |||
| try { | |||
| val snykLanguageClient = SnykLanguageClient() | |||
| languageClient = snykLanguageClient | |||
| val logLevel = if (snykLanguageClient.logger.isDebugEnabled) "debug" else "info" | |||
| val logLevel = if (snykLanguageClient.logger.isDebugEnabled) "trace" else "info" | |||
There was a problem hiding this comment.
Remove this !!
bastiandoetsch
approved these changes
May 31, 2024
teodora-sandu
force-pushed
the
feat/IDE-240-consistent-styles
branch
from
d305b01 to
6eca164
Compare
teodora-sandu
force-pushed
the
feat/IDE-240-consistent-styles
branch
from
6eca164 to
c56e584
Compare
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts custom IntelliJ styling from
snyk-lsand injects it into the HTML after compiling.scssfile to.cssusing https://github.com/EtienneMiret/sass-gradle-plugin. This requires snyk/snyk-ls#522 so that${ideStyle}is available.To test:
make build-debuginsnyk-lsin the branch from feat: remove custom styling and inject it from IDE [IDE-240] snyk-ls#522make buildin the CLI after adding a replace directive forsnyk-lsrunIdesnykCodeConsistentIgnoresFF enabled (e.g.ide-consistent-ignores-test)Checklist
Screenshots / GIFs
Without the LS change:
With the LS change: