fix: custom endpoint validation and default [IDE-131] #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
fix/custom-endpoint-validation
branch
from
0579b47 to
d65947b
Compare
teodora-sandu
force-pushed
the
fix/custom-endpoint-validation
branch
2 times, most recently
from
9de4748 to
8ed09fe
Compare
teodora-sandu
commented
May 1, 2024
| @@ -100,8 +100,7 @@ internal fun resolveCustomEndpoint(endpointUrl: String?): String { | |||
|
|
|||
| fun URI.isSnykTenant() = | |||
| isSnykDomain() | |||
| && ((host.lowercase().startsWith("app.") && path.lowercase().endsWith("/api")) | |||
| || (host.lowercase() == "snyk.io" && path.lowercase().endsWith("/api")) | |||
| && ((host.lowercase() == "snyk.io" && path.lowercase().endsWith("/api")) | |||
There was a problem hiding this comment.
The ticket mentions that we should not use app.snyk.io/api but nothing about snyk.io/api. This is a legacy way of calling APIs, as far as I know, which works today with api.snyk.io too. I think we could improve the validation some more so snyk.io/api is not allowed but it's not something we were asked to do and I don't know for sure that this wouldn't break something else so I'd rather leave it out
teodora-sandu
force-pushed
the
fix/custom-endpoint-validation
branch
from
8ed09fe to
672388c
Compare
cat2608
changed the title
cat2608
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the validation so that only
http(s)://api.APIs are configured in the custom endpoint field.Tested manually by running the extension with the latest CLI.
Checklist
Screenshots / GIFs