fix: trigger scan on startup for non-code #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
fix/scan-on-save-ls
branch
3 times, most recently
from
84be785 to
4ba0e89
Compare
bastiandoetsch
approved these changes
Apr 17, 2024
teodora-sandu
force-pushed
the
fix/scan-on-save-ls
branch
2 times, most recently
from
0ffb165 to
c9b8002
Compare
teodora-sandu
force-pushed
the
fix/scan-on-save-ls
branch
from
c9b8002 to
7adfe3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I implemented #510 I didn't realise that the LS actually has logic for scanning on startup. So because of that, we end up triggering multiple code scans and ending up in a loop because https://github.com/snyk/snyk-intellij-plugin/blob/5282559023d2d1987bd893ea78f1df585ff553e9/src/main/kotlin/io/snyk/plugin/services/SnykTaskQueueService.kt ends up saving the docs and then triggering another scan for Snyk Code.
The fix involves only triggering scan for non-Snyk Code when in LS on start-up. I've refactored the code a bit so that we are preparing ourselves for when we enable OSS and IaC in LS too for IntelliJ.
Checklist