feat: render html from snyk-ls [IDE-214] #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
teodora-sandu
force-pushed
the
feat/render-html-from-snyk-ls
branch
6 times, most recently
from
413a83a to
8229d9f
Compare
teodora-sandu
force-pushed
the
feat/render-html-from-snyk-ls
branch
from
8229d9f to
197b2e5
Compare
teodora-sandu
changed the title
cat2608
reviewed
Mar 28, 2024
src/main/kotlin/io/snyk/plugin/ui/toolwindow/panels/SuggestionDescriptionPanelFromLS.kt
Show resolved
Hide resolved
cat2608
reviewed
Mar 28, 2024
src/test/kotlin/io/snyk/plugin/ui/toolwindow/SuggestionDescriptionPanelFromLSTest.kt
Show resolved
Hide resolved
teodora-sandu
force-pushed
the
feat/render-html-from-snyk-ls
branch
from
3737bad to
436ae22
Compare
This was referenced Apr 2, 2024
bastiandoetsch
approved these changes
Apr 2, 2024
teodora-sandu
force-pushed
the
feat/render-html-from-snyk-ls
branch
from
436ae22 to
458cea8
Compare
cat2608
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
JCEFto render HTML served fromsnyk-ls. This is built using the CLI from snyk/cli#5138 and it looks incomplete because it is: styling and actions will be addressed in future PRs, as will different parts of the UI. This PR just wires up the rendering of the HTML so we can build on top of it.Tested locally by following the instructions here: https://snyksec.atlassian.net/wiki/spaces/IDE/pages/1966866488/How+to+setup+development+for+Consistent+Ignores
Checklist
Screenshots / GIFs