refactor: remove deprecations and update them to current API #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/io/snyk/plugin/settings/SnykProjectSettingsConfigurable.kt # src/main/kotlin/snyk/common/lsp/LanguageServerWrapper.kt
| @@ -47,7 +48,7 @@ class SnykCliAuthenticationService(val project: Project) { | |||
| downloadCliIfNeeded() | |||
| if (getCliFile().exists()) executeAuthCommand() | |||
| if (isAuthenticated) executeGetConfigApiCommand() | |||
|
|
|||
| LanguageServerWrapper.getInstance().updateConfiguration() | |||
There was a problem hiding this comment.
Question: Was this something we should have added before and you just noticed?
There was a problem hiding this comment.
Yeah. I noticed, that the token was not updated in Language Server after authentication. So I added it.
teodora-sandu
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
I've tested the Settings panel (changing the ignore settings and severities) and also had a look at Code Security and Code Quality issues. I haven't been able to test the other types of issues because of the bug we have with disabling/enabling other types of scanning from the Settings panel but I think it should be okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!