Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (LS-Preview) do not hang on missing answers to message requests, timeout after 5s [IDE-161] #483

Merged

Conversation

bastiandoetsch
Copy link
Collaborator

Description

Before, not answering a request message prompt from language server blocked subsequent interactions with language server. This fixes that.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner March 6, 2024 15:11
@@ -1,5 +1,9 @@
# Snyk Changelog

## [2.7.7]
### Fixed
- (LS Preview) do not hang on missing answers to message requests, timeout after 5s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this (LS Preview) communicate? Is it the same as the label (pre-alpha) added for [2.7.5]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's just marking, that this is for the preview. Before it was pre-alpha, now we're taking step by step more people on.

@bastiandoetsch bastiandoetsch merged commit 3105eff into master Mar 6, 2024
8 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-161_dont-hang-on-missing-feedback-response branch March 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants