Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (LS Preview) Snyk Code scans when having multiple projects open [IDE-160] #482

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

bastiandoetsch
Copy link
Collaborator

Description

Previously, when more than one project was opened, Snyk Code scans via Language Server were not working. This PR fixes that behaviour, by

a) maintaining a content-root specific scan state and
b) triggering scans by content root

Content roots are mirrored in Language Server as WorkspaceFolders

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner March 6, 2024 09:26
Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@bastiandoetsch bastiandoetsch merged commit fc7fa7b into master Mar 7, 2024
8 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-160_fix_multi_project_scanning branch March 7, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants