fix: this fixes the dataflow and the issue navigation #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat2608
reviewed
Feb 22, 2024
| val codeResultsLS = snykCachedResults.currentSnykCodeResultsLS ?: return@invokeLater | ||
| val codeResultsLS = snykCachedResults.currentSnykCodeResultsLS |
There was a problem hiding this comment.
We got rid of this null check because of the WIP here?
cat2608
approved these changes
Feb 22, 2024
bastiandoetsch
merged commit 7de0dd6
into
feat/IDE-134_show-snyk-code-findings-in-custom-ui
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue navigation didn't work correctly because of sorting of the issue map. Also, the dataflow was based on markers, which is not sufficient. Therefore it now takes the dataflow from language server (needs snyk/snyk-ls#449).
This is a stacked PR on top of #474.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!